Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make unit converter use a factory to avoid looking up the ratios each conversion #93706

Merged
merged 34 commits into from
May 29, 2023
Merged

Make unit converter use a factory to avoid looking up the ratios each conversion #93706

merged 34 commits into from
May 29, 2023

Commits on May 28, 2023

  1. Make a unit converter factory for statistics 

    With statistics we are doing the same conversion over and over
and we have do do lookups every time to do the convert. Since
its the same to/from unit over and over we can use a factory
pattern to avoid all the lookups
    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    27b9e9d View commit details
    Browse the repository at this point in the history

  2. move more code

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    fbfb63b View commit details
    Browse the repository at this point in the history

  3. move more code

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    be76b9e View commit details
    Browse the repository at this point in the history

  4. move more code

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    9d0404e View commit details
    Browse the repository at this point in the history

  5. reduce

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    6fbeb81 View commit details
    Browse the repository at this point in the history

  6. fix

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    ea2ddfd View commit details
    Browse the repository at this point in the history

  7. coverage

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    e0c8704 View commit details
    Browse the repository at this point in the history

  8. fix

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    ab5f6e5 View commit details
    Browse the repository at this point in the history

  9. fix

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    d13f47d View commit details
    Browse the repository at this point in the history

  10. fix

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    a756be6 View commit details
    Browse the repository at this point in the history

  11. same unit test

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    03193b6 View commit details
    Browse the repository at this point in the history

  12. dry

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    e2ceea8 View commit details
    Browse the repository at this point in the history

  13. simplify

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    42522cc View commit details
    Browse the repository at this point in the history

  14. dry

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    ae0f99c View commit details
    Browse the repository at this point in the history

  15. dry

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    1c9b799 View commit details
    Browse the repository at this point in the history

  16. one was missing approx

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    2c66457 View commit details
    Browse the repository at this point in the history

  17. preserve compat

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    2d23838 View commit details
    Browse the repository at this point in the history

  18. reduce loss

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    d92d509 View commit details
    Browse the repository at this point in the history

  19. reduce loss

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    faad2d6 View commit details
    Browse the repository at this point in the history

  20. reduce loss

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    efdfd22 View commit details
    Browse the repository at this point in the history

  21. reduce loss

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    8fac81d View commit details
    Browse the repository at this point in the history

  22. reduce loss

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    4669b75 View commit details
    Browse the repository at this point in the history

  23. remove one lru

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    9c97ca7 View commit details
    Browse the repository at this point in the history

  24. remove one lru

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    392c1be View commit details
    Browse the repository at this point in the history

  25. adjust

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    c6a928c View commit details
    Browse the repository at this point in the history

  26. adjust

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    992f94b View commit details
    Browse the repository at this point in the history

  27. dry it up

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    dadeb22 View commit details
    Browse the repository at this point in the history

  28. adjust

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    9df98f4 View commit details
    Browse the repository at this point in the history

  29. reduce

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    1b387e8 View commit details
    Browse the repository at this point in the history

  30. cleanup cover

    @bdraco
    bdraco committed May 28, 2023
    Configuration menu
    Copy the full SHA
    e6db2ed View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. add missing coverage

    @bdraco
    bdraco committed May 29, 2023
    Configuration menu
    Copy the full SHA
    1d4bf6b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into convert_factory

    @bdraco
    bdraco committed May 29, 2023
    Configuration menu
    Copy the full SHA
    553a55d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into convert_factory

    @bdraco
    bdraco committed May 29, 2023
    Configuration menu
    Copy the full SHA
    cf4b538 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into convert_factory

    @bdraco
    bdraco committed May 29, 2023
    Configuration menu
    Copy the full SHA
    6aa84be View commit details
    Browse the repository at this point in the history