Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit inference for ITEMP field for APCUPSD integration #93724

Merged
merged 2 commits into from May 29, 2023
Merged

Fix unit inference for ITEMP field for APCUPSD integration #93724

merged 2 commits into from May 29, 2023

Conversation

yuxincs
Copy link
Contributor

@yuxincs yuxincs commented May 29, 2023

Proposed change

APCUPSd weirdly adds a trailing "Internal" for internal temperature ITEMP field (e.g., "30.5 C Internal" instead of "30.5 C"), which broke our simple unit inference / conversion algorithm in the integration. This PR adds unit inference support for ITEMP field reported from APCUPSd by adding a fake unit "C Internal" in the unit conversion dict.

Tests are also expanded to include such cases to prevent future regressions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@yuxincs yuxincs changed the title Apcupsd fix unit inference for itemp Fix unit inference for ITEMP field for APCUPSd May 29, 2023
@yuxincs yuxincs changed the title Fix unit inference for ITEMP field for APCUPSd Fix unit inference for ITEMP field for APCUPSD integration May 29, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yuxincs 👍

../Frenck

@frenck frenck merged commit a547181 into home-assistant:dev May 29, 2023
24 checks passed
@yuxincs yuxincs deleted the apcupsd-fix-unit-inference-for-itemp branch May 30, 2023 02:51
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apcupsd: multiple sensors no longer reporting data
2 participants