New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework mqtt climate platform to simplify implementation water_heater platform #93751
Conversation
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@hookedonunix I also have splitted the climate specific parts from the common parts. Initially I added them together, but I guess it starts getting messy if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jbouwh 👍
Looks great, thank you! |
Proposed change
PR #93644 implements the
water_heater
platform. This platform has a lot in common with theclimate
platform.This PR isolates the code that can be shared to set up both entity types.
The new
MqttTemperatureControlEntity
class implementsMqttEntity
and implements the shared code to subscribe to topics, handle incoming messages, and control target temperature.The
MqttClimate
base class inherritsMqttTemperatureControlEntity
.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: