Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import util.dt as dt_util in remaining tests, enforce with ruff #93765

Merged
merged 3 commits into from May 30, 2023

Conversation

scop
Copy link
Member

@scop scop commented May 29, 2023

Proposed change

Datetime related module names are unfortunate, but being consistent with how they're imported helps. The whole components tree has been made to import homeassistant.util.dt as dt_util, this PR contains the remaining changes in other parts of the tree, and makes ruff enforce the naming.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@scop scop requested a review from a team as a code owner May 29, 2023 21:12
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @scop 👍

../Frenck

@scop
Copy link
Member Author

scop commented May 29, 2023

Cheers, thanks for the quick reviews 👍

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test failures remain, could you take a look?

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 30, 2023 06:22
@scop scop marked this pull request as ready for review May 30, 2023 19:54
@scop scop requested a review from azogue as a code owner May 30, 2023 19:54
@home-assistant home-assistant bot requested a review from frenck May 30, 2023 19:54
@scop scop merged commit c7c4ee1 into dev May 30, 2023
47 of 48 checks passed
@scop scop deleted the scop-util-dt-import-alias_rest branch May 30, 2023 20:30
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants