Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "days" unit for STESTI sensor in APCUPSD integration #93844

Merged
merged 1 commit into from May 31, 2023
Merged

Add support for "days" unit for STESTI sensor in APCUPSD integration #93844

merged 1 commit into from May 31, 2023

Conversation

yuxincs
Copy link
Contributor

@yuxincs yuxincs commented May 31, 2023

Breaking change

sensor.ups_self_test_interval sensor now properly splits unit "days" from the raw data. Previously, it will show 7 days as sensor state, now it shows 7 with a unit UnitOfTime.DAYS.

Proposed change

Although APCUPSD manual suggests that STESTI field will report the interval in hours, we have reports from users that it can actually contain numeric values with units days, e.g., 7 days.
#93132 (comment)
#81476 (comment)

This PR adds support for days unit and properly splits the unit from the raw strings instead. Also, this PR removes the state class of this sensor since it is not total_increasing, it is actually a user-configurable option.

Tests for STESTI have been added to prevent future regressions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @yuxincs

@emontnemery emontnemery merged commit 676b6ab into home-assistant:dev May 31, 2023
24 checks passed
@yuxincs yuxincs deleted the apcupsd-fix-stesti-units branch May 31, 2023 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apcupsd: multiple sensors no longer reporting data
2 participants