Add support for "days" unit for STESTI sensor in APCUPSD integration #93844
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
sensor.ups_self_test_interval
sensor now properly splits unit "days" from the raw data. Previously, it will show7 days
as sensor state, now it shows7
with a unitUnitOfTime.DAYS
.Proposed change
Although APCUPSD manual suggests that
STESTI
field will report the interval in hours, we have reports from users that it can actually contain numeric values with unitsdays
, e.g.,7 days
.#93132 (comment)
#81476 (comment)
This PR adds support for
days
unit and properly splits the unit from the raw strings instead. Also, this PR removes the state class of this sensor since it is nottotal_increasing
, it is actually a user-configurable option.Tests for
STESTI
have been added to prevent future regressions.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: