Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve no-yaml warning #93851

Merged
merged 1 commit into from May 31, 2023
Merged

Improve no-yaml warning #93851

merged 1 commit into from May 31, 2023

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented May 31, 2023 •
edited

Proposed change

Improve no-yaml warning introduced by #93589

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner May 31, 2023 06:53
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels May 31, 2023
jbouwh
jbouwh approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,
Thnx @emontnemery !

@emontnemery emontnemery merged commit ef4dea0 into dev May 31, 2023
48 checks passed
@emontnemery emontnemery deleted the tweak_no_yaml_warning branch May 31, 2023 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@jbouwh jbouwh jbouwh approved these changes

Assignees
No one assigned
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The mqtt integration does not support YAML setup, please remove it from your configuration
3 participants
@emontnemery @frenck @jbouwh