Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in tibber while fetching latest statistics #93998

Merged
merged 1 commit into from Jun 3, 2023

Conversation

tronikos
Copy link
Contributor

@tronikos tronikos commented Jun 3, 2023

Proposed change

Fix exception in beta caused by #92095
{} is dict but the function expects a set so change it to set()

Error is:
'dict' object has no attribute 'discard'

Note I don't use tibber. I only noticed it because my opower integration #90489 that has the same function call encountered this exception

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Fix exception caused by home-assistant#92095
{} is dict but the function expects a set so change it to set()
@home-assistant
Copy link

home-assistant bot commented Jun 3, 2023

Hey there @Danielhiversen, mind taking a look at this pull request as it has been labeled with an integration (tibber) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tibber can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tibber Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@tronikos tronikos marked this pull request as ready for review June 3, 2023 10:37
@tronikos
Copy link
Contributor Author

tronikos commented Jun 3, 2023

@bdraco For backwards compatibility you might want to allow the types in _extract_metadata_and_discard_impossible_columns function to be empty dict.

@bdraco bdraco added this to the 2023.6.0 milestone Jun 3, 2023
@bdraco
Copy link
Member

bdraco commented Jun 3, 2023

Traveling today but will look at this when I get through security

@bdraco
Copy link
Member

bdraco commented Jun 3, 2023

Looks like this came in via #82131

I missed it in review.

It is typed correctly.

Not sure why mypy didn't catch it

@bdraco bdraco changed the title Fix tibber in beta Fix error in tibber while fetching latest statistics Jun 3, 2023
@bdraco
Copy link
Member

bdraco commented Jun 3, 2023

Thanks @tronikos

I didn't add bug for bug backwards compatibility here since the typing is correct and it blows up with a rather obvious error so I don't think we will have bugs hiding out for long if someone also has made it an empty dict

@bdraco bdraco merged commit faacf16 into home-assistant:dev Jun 3, 2023
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants