Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the sensor state using the coordinatordata instead of initial data #94008

Merged
merged 3 commits into from Jun 3, 2023

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Jun 3, 2023

Proposed change

Apparently there was a bug in the YouTube integration. On initialization of the entity _channel got set, on which the _fn's got called. Even if the coordinator updates, the _channel never got updated so the state of the entity stayed the same.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek joostlek marked this pull request as ready for review June 3, 2023 18:02
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not need to check available in the entity setup.

@home-assistant
Copy link

home-assistant bot commented Jun 3, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 3, 2023 18:09
@balloob balloob added this to the 2023.6.0 milestone Jun 3, 2023
@joostlek joostlek marked this pull request as ready for review June 3, 2023 18:10
@home-assistant home-assistant bot requested a review from balloob June 3, 2023 18:10
@balloob balloob merged commit efb92ca into home-assistant:dev Jun 3, 2023
24 checks passed
@joostlek joostlek deleted the youtube_coordinator branch June 3, 2023 18:36
@balloob
Copy link
Member

balloob commented Jun 3, 2023

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants