Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump xiaomi-ble to 0.17.2 #94011

Merged
merged 2 commits into from Jun 5, 2023
Merged

Conversation

Ernst79
Copy link
Contributor

@Ernst79 Ernst79 commented Jun 3, 2023

Proposed change

Bump xiaomi-ble to 0.17.2 to fix JTYJGD03MI smoke detector wrongly being detected as a temperature sensor

Change log xiaomi-ble: https://github.com/Bluetooth-Devices/xiaomi-ble/releases/tag/v0.17.2
Bluetooth-Devices/xiaomi-ble@v0.17.0...v0.17.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 3, 2023

Hey there @Jc2k, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_ble) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of xiaomi_ble can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign xiaomi_ble Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@Ernst79 Ernst79 marked this pull request as ready for review June 3, 2023 19:22
@Ernst79 Ernst79 requested a review from Jc2k as a code owner June 3, 2023 19:22
@bdraco bdraco changed the title Bump xiaomi-ble Bump xiaomi-ble to 0.17.2 Jun 3, 2023
@bdraco bdraco added this to the 2023.6.0 milestone Jun 3, 2023
@bdraco
Copy link
Member

bdraco commented Jun 3, 2023

This was over 1000 commits behind dev so merging in dev to make sure CI still passes

@Ernst79
Copy link
Contributor Author

Ernst79 commented Jun 3, 2023

Thanks

@ctalkington ctalkington merged commit 7c02e1c into home-assistant:dev Jun 5, 2023
48 checks passed
balloob pushed a commit that referenced this pull request Jun 5, 2023
Bump xiaomi-ble

Co-authored-by: J. Nick Koston <nick@koston.org>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
@Ernst79 Ernst79 deleted the smoke_sensor branch January 20, 2024 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JTYJGD03MI is defined as a thermometer but is a smoke detector.
5 participants