Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop codeowner for gogogate2 #94049

Merged
merged 1 commit into from Jun 4, 2023
Merged

Drop codeowner for gogogate2 #94049

merged 1 commit into from Jun 4, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 4, 2023

Proposed change

I replaced my ismartgates with 2x https://www.kincony.com/kc868-a8-hardware-design-details.html running esphome because I wanted two way feedback and push updates. I am no longer using the ismartgate hardware so I am dropping codeowner for this integration.

Feel free to ping me about any code I've written for this in the past.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I replaced my ismartgates with 2x https://www.kincony.com/kc868-a8-hardware-design-details.html
running esphome because I wanted two way feedback and push updates. I am no longer using
the ismartgate hardware so I am dropping codeowner for this integration
@home-assistant
Copy link

home-assistant bot commented Jun 4, 2023

Hey there @vangorra, mind taking a look at this pull request as it has been labeled with an integration (gogogate2) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of gogogate2 can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign gogogate2 Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco
Copy link
Member Author

bdraco commented Jun 4, 2023

For anyone curious about the gate config for esphome (I'm sure it can still be improved). Note: I removed all the secrets (encryption key)

The kc868-a4 would have been a better choice for hardware, but I had a lot of the kc868-a8 so I used what I had.

https://www.liftmaster.com/sl3000ul-slide-gate-operator/p/SL3000UL

---

substitutions:
  id_prefix: driveway_gate
  devicename: drivewaygate
  upper_devicename: Driveway Gate
  close_duration: 34.1sec
  open_duration: 33.5sec
  optimistic_close_duration: 33.5sec
  optimistic_open_duration: 32.5sec
  max_duration: 35.0sec
  direction_change_wait_time: 1.0sec


esphome:
  name: ${devicename}


# Enable over-the-air updates.
ota:

  
esp32:
  board: esp32dev
  framework:
    type: esp-idf


# Example configuration entry for ESP32
i2c:
  sda: 4
  scl: 5
  scan: true
  id: bus_a

# Example configuration entry
ethernet:
  type: LAN8720
  mdc_pin: GPIO23
  mdio_pin: GPIO18
  clk_mode: GPIO17_OUT
  phy_addr: 0

# Example configuration entry
pcf8574:
  - id: "pcf8574_hub_out_1" # for output channel 1-8
    address: 0x24

  - id: "pcf8574_hub_in_1" # for input channel 9-16
    address: 0x22

# Individual outputs
switch:
  - platform: gpio
    pin:
      pcf8574: pcf8574_hub_out_1
      number: 0
      mode: OUTPUT
      inverted: true
    name: "${upper_devicename} Open"
    id: ${id_prefix}_open
    on_turn_on:
      - globals.set:
          id: ${id_prefix}_opening
          value: 'true'    
      - globals.set:
          id: ${id_prefix}_closing
          value: 'false'               
  - platform: gpio
    pin:
      pcf8574: pcf8574_hub_out_1
      number: 1
      mode: OUTPUT
      inverted: true
    name: "${upper_devicename} Close"
    id: ${id_prefix}_close
    on_turn_on:
      - globals.set:
          id: ${id_prefix}_opening
          value: 'false'    
      - globals.set:
          id: ${id_prefix}_closing
          value: 'true'           

  - platform: gpio
    pin:
      pcf8574: pcf8574_hub_out_1
      number: 2
      mode: OUTPUT
      inverted: true
    name: "${upper_devicename} Stop"
    id: ${id_prefix}_stop
    on_turn_on:
      - globals.set:
          id: ${id_prefix}_opening
          value: 'false'    
      - globals.set:
          id: ${id_prefix}_closing
          value: 'false'           



binary_sensor:
  - platform: gpio
    id: ${id_prefix}_opened
    name: ${upper_devicename} Opened
    pin:
      pcf8574: pcf8574_hub_in_1
      number: 0
      mode: INPUT
      inverted: true
    on_release:
      then:
        - globals.set:
            id: ${id_prefix}_closing
            value: 'true'   
        - delay: ${optimistic_close_duration}
        - globals.set:
            id: ${id_prefix}_closing
            value: 'false'   
  - platform: gpio
    id: ${id_prefix}_closed
    name: ${upper_devicename} Closed 
    pin:
      pcf8574: pcf8574_hub_in_1
      number: 1
      mode: INPUT
      inverted: true
    on_release:
      then:
        - globals.set:
            id: ${id_prefix}_opening
            value: 'true'    
        - delay: ${optimistic_open_duration}
        - globals.set:
            id: ${id_prefix}_opening
            value: 'false'
  - platform: gpio
    id: ${id_prefix}_moving
    name: ${upper_devicename} Moving
    pin:
      pcf8574: pcf8574_hub_in_1
      number: 2
      mode: INPUT
      inverted: true
              
  - platform: template
    name: "${upper_devicename} Closing"
    id: ${id_prefix}_closing_sensor
    lambda: |-
      if (id(${id_prefix}_moving) and id(${id_prefix}_closing)) {
        return true;
      } else {
        return false;
      }
  - platform: template
    name: "${upper_devicename} Opening"
    id: ${id_prefix}_opening_sensor
    lambda: |-
      if (id(${id_prefix}_moving) and id(${id_prefix}_opening)) {
        return true;
      } else {
        return false;
      }


# Enable logging
logger:
 level: VERBOSE

# Enable Home Assistant API
api:

# Sync time with Home Assistant.
time:
  - platform: homeassistant
    id: homeassistant_time

# Text sensors with general information.
text_sensor:
  # Expose ESPHome version as sensor.
  - platform: version
    name: ${upper_devicename} ESPHome Version

# Sensors with general information.
sensor:
  # Uptime sensor.
  - platform: uptime
    name: ${upper_devicename} Uptime


globals:
  - id: ${id_prefix}_closing
    type: bool
    restore_value: false
    initial_value: "false"
  - id: ${id_prefix}_opening
    type: bool
    restore_value: false
    initial_value: "false"
    

cover:
  - platform: feedback
    name: ${upper_devicename}
    id: ${id_prefix}
    device_class: gate
    max_duration: ${max_duration}
    direction_change_wait_time: ${direction_change_wait_time}

    open_action:
      - switch.turn_off: ${id_prefix}_stop
      - switch.turn_on: ${id_prefix}_open
      - delay: 200ms #allow for switching time and any discharge
      - switch.turn_off: ${id_prefix}_open
    open_duration: ${open_duration}
    open_endstop: ${id_prefix}_opened
    open_sensor: ${id_prefix}_opening_sensor

    close_action:
      - switch.turn_off: ${id_prefix}_stop
      - switch.turn_on: ${id_prefix}_close
      - delay: 200ms #allow for switching time and any discharge
      - switch.turn_off: ${id_prefix}_close

    close_duration: ${close_duration}
    close_endstop: ${id_prefix}_closed
    close_sensor: ${id_prefix}_closing_sensor


    stop_action:
      - switch.turn_on: ${id_prefix}_stop
      - switch.turn_off: ${id_prefix}_close
      - switch.turn_off: ${id_prefix}_open
      - delay: 200ms #allow for switching time and any discharge
      - switch.turn_off: ${id_prefix}_stop

https://www.liftmaster.com/24vdc-high-traffic-commercial-slide-gate-operator/p/CSL24UL

---

substitutions:
  id_prefix: north_gate
  devicename: northgate
  upper_devicename: North Gate
  close_duration: 14.5sec
  open_duration: 12.5sec
  optimistic_close_duration: 13.5sec
  optimistic_open_duration: 11.5sec
  max_duration: 16.0sec
  direction_change_wait_time: 5.0sec


esphome:
  name: ${devicename}


# Enable over-the-air updates.
ota:

  
esp32:
  board: esp32dev
  framework:
    type: esp-idf


# Example configuration entry for ESP32
i2c:
  sda: 4
  scl: 5
  scan: true
  id: bus_a

# Example configuration entry
ethernet:
  type: LAN8720
  mdc_pin: GPIO23
  mdio_pin: GPIO18
  clk_mode: GPIO17_OUT
  phy_addr: 0

# Example configuration entry
pcf8574:
  - id: "pcf8574_hub_out_1" # for output channel 1-8
    address: 0x24

  - id: "pcf8574_hub_in_1" # for input channel 9-16
    address: 0x22

# Individual outputs
switch:
  - platform: gpio
    pin:
      pcf8574: pcf8574_hub_out_1
      number: 0
      mode: OUTPUT
      inverted: true
    name: "${upper_devicename} Open"
    id: ${id_prefix}_open
    on_turn_on:
      - globals.set:
          id: ${id_prefix}_opening
          value: 'false'    
      - globals.set:
          id: ${id_prefix}_closing
          value: 'false'               
  - platform: gpio
    pin:
      pcf8574: pcf8574_hub_out_1
      number: 1
      mode: OUTPUT
      inverted: true
    name: "${upper_devicename} Close"
    id: ${id_prefix}_close
    on_turn_on:
      - globals.set:
          id: ${id_prefix}_opening
          value: 'false'    
      - globals.set:
          id: ${id_prefix}_closing
          value: 'false'           

  - platform: gpio
    pin:
      pcf8574: pcf8574_hub_out_1
      number: 2
      mode: OUTPUT
      inverted: true
    name: "${upper_devicename} Stop"
    id: ${id_prefix}_stop
    on_turn_on:
      - globals.set:
          id: ${id_prefix}_opening
          value: 'false'    
      - globals.set:
          id: ${id_prefix}_closing
          value: 'false'           



binary_sensor:
  - platform: gpio
    id: ${id_prefix}_opened
    name: ${upper_devicename} Opened
    pin:
      pcf8574: pcf8574_hub_in_1
      number: 0
      mode: INPUT
      inverted: true
    on_release:
      then:
        - globals.set:
            id: ${id_prefix}_closing
            value: 'true'   
        - delay: ${optimistic_close_duration}
        - globals.set:
            id: ${id_prefix}_closing
            value: 'false'   
  - platform: gpio
    id: ${id_prefix}_closed
    name: ${upper_devicename} Closed 
    pin:
      pcf8574: pcf8574_hub_in_1
      number: 1
      mode: INPUT
      inverted: true
    on_release:
      then:
        - globals.set:
            id: ${id_prefix}_opening
            value: 'true'    
        - delay: ${optimistic_open_duration}
        - globals.set:
            id: ${id_prefix}_opening
            value: 'false'
  - platform: gpio
    id: ${id_prefix}_nearly_closed
    name: ${upper_devicename} Nearly Closed
    pin:
      pcf8574: pcf8574_hub_in_1
      number: 2
      mode: INPUT
      inverted: true
              
  - platform: template
    name: "${upper_devicename} Closing"
    id: ${id_prefix}_closing_sensor
    lambda: |-
      if (id(${id_prefix}_closing)) {
        return true;
      } else {
        return false;
      }
  - platform: template
    name: "${upper_devicename} Opening"
    id: ${id_prefix}_opening_sensor
    lambda: |-
      if (id(${id_prefix}_opening)) {
        return true;
      } else {
        return false;
      }


# Enable logging
logger:

# Enable Home Assistant API
api:

# Sync time with Home Assistant.
time:
  - platform: homeassistant
    id: homeassistant_time

# Text sensors with general information.
text_sensor:
  # Expose ESPHome version as sensor.
  - platform: version
    name: ${upper_devicename} ESPHome Version

# Sensors with general information.
sensor:
  # Uptime sensor.
  - platform: uptime
    name: ${upper_devicename} Uptime


globals:
  - id: ${id_prefix}_closing
    type: bool
    restore_value: false
    initial_value: "false"
  - id: ${id_prefix}_opening
    type: bool
    restore_value: false
    initial_value: "false"
    

cover:
  - platform: feedback
    name: ${upper_devicename}
    id: ${id_prefix}
    device_class: gate
    max_duration: ${max_duration}
    direction_change_wait_time: ${direction_change_wait_time}

    open_action:
      - switch.turn_off: ${id_prefix}_stop
      - switch.turn_on: ${id_prefix}_open
      - delay: 200ms #allow for switching time and any discharge
      - switch.turn_off: ${id_prefix}_open
    open_duration: ${open_duration}
    open_endstop: ${id_prefix}_opened
    open_sensor: ${id_prefix}_opening_sensor

    close_action:
      - switch.turn_off: ${id_prefix}_stop
      - switch.turn_on: ${id_prefix}_close
      - delay: 200ms #allow for switching time and any discharge
      - switch.turn_off: ${id_prefix}_close

    close_duration: ${close_duration}
    close_endstop: ${id_prefix}_closed
    close_sensor: ${id_prefix}_closing_sensor


    stop_action:
      - switch.turn_on: ${id_prefix}_stop
      - switch.turn_off: ${id_prefix}_close
      - switch.turn_off: ${id_prefix}_open
      - delay: 200ms #allow for switching time and any discharge
      - switch.turn_off: ${id_prefix}_stop

@ctalkington ctalkington merged commit 0988292 into dev Jun 4, 2023
20 checks passed
@ctalkington ctalkington deleted the gogogate2_drop branch June 4, 2023 23:42
@bdraco
Copy link
Member Author

bdraco commented Jun 4, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants