-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preset support to electrasmart climate #94068
Conversation
Fixing back ElectraSmart component, adding capability to enable the Shabat mode present in code already
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
@bokobok, did you verify the functionality with the current code? (I know you did back then with the custom integration) |
@jafar-atili I honestly do not know how to check the entire core The function needed for the preset ability is present: climate.py:308 (async_set_preset_mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @rubeecube 👍
This comment was marked as duplicate.
This comment was marked as duplicate.
Hi @rubeecube It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rubeecube Can you please make sure you sign the CLA?
We can't merge this if the CLA isn't signed.
Thanks! 👍
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@frenck done! |
Thanks for the quick turnaround @rubeecube 👍 ../Frenck |
Fixing back ElectraSmart component, adding capability to enable the Shabat mode present in code already
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: