Clean up error logging in qbittorrent #94071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
integration: qbittorrent
small-pr
|
Hey there @geoffreylagaisse, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
19 tasks
|
CI failure is unrelated. |
epenet
reviewed
Jun 5, 2023
| @@ -35,11 +35,9 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: | |||
| entry.data[CONF_VERIFY_SSL], | |||
| ) | |||
| except LoginRequired as err: | |||
| _LOGGER.error("Invalid credentials") | |||
| raise ConfigEntryNotReady from err | |||
| raise ConfigEntryNotReady("Invalid credentials") from err | |||
There was a problem hiding this comment.
Note: is there a plan to implement reauth?
There was a problem hiding this comment.
Not at this moment, but I'll look into it when I have more time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve error logging & exceptions in
qbittorrent. Instead of logging errors then raising exceptions, log messages are passed as exception argument. This applies when raisingConfigEntryNotReadyin__init__.pyType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: