Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shorthand attributes in NextBus #94084

Merged
merged 3 commits into from Jun 6, 2023

Conversation

ViViDboarder
Copy link
Contributor

Proposed change

Use self._attr_* rather than properties to set values in NextBus sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@ViViDboarder
Copy link
Contributor Author

@epenet Here's the requested PR.

@ViViDboarder ViViDboarder mentioned this pull request Jun 5, 2023
20 tasks
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

homeassistant/components/nextbus/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/nextbus/sensor.py Show resolved Hide resolved
homeassistant/components/nextbus/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 5, 2023 19:26
@home-assistant
Copy link

home-assistant bot commented Jun 5, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ViViDboarder ViViDboarder marked this pull request as ready for review June 5, 2023 19:35
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final remark on unique_id

homeassistant/components/nextbus/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 5, 2023 20:12
@ViViDboarder ViViDboarder changed the title NextBus: Use attr with unique id NextBus: Use attr instead of properties Jun 5, 2023
@ViViDboarder ViViDboarder marked this pull request as ready for review June 5, 2023 21:07
@ViViDboarder
Copy link
Contributor Author

Thanks for the quick reviews, @gjohansson-ST!

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epenet epenet changed the title NextBus: Use attr instead of properties Use shorthand attributes in NextBus Jun 6, 2023
@epenet epenet merged commit 4b46609 into home-assistant:dev Jun 6, 2023
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants