Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Brottsplatskartan YAML configuration #94101

Merged
merged 1 commit into from Jun 12, 2023
Merged

Conversation

gjohansson-ST
Copy link
Member

Breaking change

Configuring Brottsplatskartan via YAML was deprecated in Home Assistant Core 2023.5 and support has now been removed.
The YAML configuration was automatically imported to a config entry by release Home Assistant Core 2023.5. Please remove Brottsplatskartan YAML configuration from your configuration.yaml file.

Proposed change

Remove platform yaml brottsplatskartan, deprecation started in 2023.5 and is now ended after 2 releases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we should keep the schema a bit longer and use cv.removed validators.

@gjohansson-ST
Copy link
Member Author

May be we should keep the schema a bit longer and use cv.removed validators.

@jbouwh not needed as it's built in to the async_setup function in platform setup https://github.com/home-assistant/core/blob/dev/homeassistant/helpers/entity_platform.py#L195

@jbouwh
Copy link
Contributor

jbouwh commented Jun 6, 2023

May be we should keep the schema a bit longer and use cv.removed validators.

@jbouwh not needed as it's built in to the async_setup function in platform setup https://github.com/home-assistant/core/blob/dev/homeassistant/helpers/entity_platform.py#L195

Yeah, you are right, this was added recently I believe.

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @gjohansson-ST 👍

@gjohansson-ST gjohansson-ST merged commit ce02261 into dev Jun 12, 2023
24 checks passed
@gjohansson-ST gjohansson-ST deleted the bpk-remove-import branch June 12, 2023 09:28
mover85 pushed a commit to mover85/core that referenced this pull request Jun 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants