Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dual IP stack support to HomeKit #94126

Merged
merged 25 commits into from Jun 25, 2023
Merged

Add dual IP stack support to HomeKit #94126

merged 25 commits into from Jun 25, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 6, 2023

Proposed change

needs ikalchev/HAP-python#442
needs #94812
needs #94816

HomeKit now announces all IPs configured by the network integration which matches the same behavior we use to announce Home Assistant itself in the zeroconf integration.

This should fix a whole lot of users with multiple interfaces / IPv6. I did not mark specific issues because so many of the issues in the queue are network issues and its not possible to know which ones this will resolve without knowing users network layouts.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 6, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (network) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of network can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign network Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco marked this pull request as ready for review June 18, 2023 20:06
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 21, 2023
@bdraco
Copy link
Member Author

bdraco commented Jun 23, 2023

Merging in dev to retest to make sure everything still working ok with other recent changes

@bdraco
Copy link
Member Author

bdraco commented Jun 23, 2023

Retest is good

@bdraco
Copy link
Member Author

bdraco commented Jun 23, 2023

CI was flaking. merged in again

@balloob balloob merged commit ef2e55e into dev Jun 25, 2023
23 checks passed
@balloob balloob deleted the hk_dual_stack branch June 25, 2023 03:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants