Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Climate min/max temp with Google Assistant #94143

Merged
merged 2 commits into from Jun 8, 2023

Conversation

hookedonunix
Copy link
Contributor

Proposed change

A change to the TempetureSettingTrait in the Google Assistant integration to also return the min_temp and max_temp attributes during a sync request. Both temps are converted into Celsius for the request and tests have been modified to suit this change.
I couldn't see any documentation that makes a note of this functionality.

This was identified by @balloob during this PR for the water heater platform.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 7, 2023

Hey there @home-assistant/cloud, mind taking a look at this pull request as it has been labeled with an integration (google_assistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_assistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign google_assistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@hookedonunix
Copy link
Contributor Author

The second commit fixes some missed code coverage I found on the TemperatureSettingTrait while testing. Happy to break that into another PR if that is preferred though

@hookedonunix hookedonunix marked this pull request as ready for review June 7, 2023 06:01
@balloob balloob requested a review from emontnemery June 7, 2023 18:37
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working with the Google Home app 👍

Also, this appears to fix #92661 without having to disable local control 🚀
Edit: It doesn't fix local control.

@emontnemery emontnemery added this to the 2023.6.1 milestone Jun 7, 2023
@balloob balloob merged commit 85a12c3 into home-assistant:dev Jun 8, 2023
52 checks passed
@emontnemery emontnemery removed this from the 2023.6.1 milestone Jun 8, 2023
@hookedonunix hookedonunix deleted the google-assistant-climate branch June 8, 2023 06:43
@hookedonunix hookedonunix restored the google-assistant-climate branch June 8, 2023 06:43
@hookedonunix hookedonunix deleted the google-assistant-climate branch June 8, 2023 06:43
@hookedonunix hookedonunix restored the google-assistant-climate branch June 8, 2023 06:44
@hookedonunix
Copy link
Contributor Author

Cheers! That local control issue looks painful

@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants