Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require pydantic 1.10.8 or higher #94208

Merged
merged 4 commits into from Jun 8, 2023

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Jun 8, 2023

Proposed change

Constrain to a newer version of pydantic which seems to resolve #93904 according to reports.

Changes: pydantic/pydantic@v1.9.1...v1.10.8
Related, we've been testing on newer versions already:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@allenporter
Copy link
Contributor Author

I think this may be conflicting...

python-opensky 0.0.8 depends on pydantic==1.10.8

@allenporter allenporter changed the title Requied pydantic 1.10.9 or higher Require pydantic 1.10.8 or higher Jun 8, 2023
@MartinHjelmare
Copy link
Member

Please run script/gen_requirements_all.py.

@MartinHjelmare MartinHjelmare added this to the 2023.6.1 milestone Jun 8, 2023
@MartinHjelmare MartinHjelmare merged commit 52ba58c into home-assistant:dev Jun 8, 2023
52 checks passed
@cdce8p
Copy link
Member

cdce8p commented Jun 8, 2023

I think this may be conflicting...

python-opensky 0.0.8 depends on pydantic==1.10.8

FYI: Opened joostlek/python-opensky#45 to resolve the dependency conflict upstream.

@joostlek joostlek mentioned this pull request Jun 8, 2023
20 tasks
balloob pushed a commit that referenced this pull request Jun 8, 2023
* Requied pydantic 1.10.9 or higher

* Simplify constraint to 2.0

* Drop constraint by one patch release to 1.10.8 or higher

* Add package constraints to gen requirements script
@balloob balloob mentioned this pull request Jun 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Calendar - Unexpected exception importing platform homeassistant.components.local_calendar.calendar
4 participants