Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set httpx log level to warning #94217

Merged
merged 1 commit into from Jun 8, 2023

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Jun 8, 2023

Breaking change

None

Proposed change

With version 0.24.1 of httpx, the log level for logging HTTP requests was changed from debug to info.
This causes log flooding depending on how many integrations are active that use httpx.

Therefore, this PR changes the default log level to warning, like the other HTTP libraries.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@jpbede jpbede requested a review from a team as a code owner June 8, 2023 05:39
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Jun 8, 2023
@epenet epenet added this to the 2023.6.1 milestone Jun 8, 2023
@epenet
Copy link
Contributor

epenet commented Jun 8, 2023

If approved, I think it might make sense to include in patch release.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 99ee4e8 into home-assistant:dev Jun 8, 2023
52 checks passed
@jpbede jpbede deleted the fix/httpx-loglevel branch June 8, 2023 08:37
balloob pushed a commit that referenced this pull request Jun 8, 2023
Set log level of httpx to warning
@balloob balloob mentioned this pull request Jun 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log spammed with httpx since 2023.5.4
4 participants