Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aioairzone-cloud to v0.1.8 #94223

Merged
merged 1 commit into from Jun 8, 2023

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Jun 8, 2023

Proposed change

Update aioairzone-cloud to v0.1.8.
Should fix the following issue: #94193

Releases:

Git compare: Noltari/aioairzone-cloud@0.1.7...0.1.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Copy link
Contributor

@freeDom- freeDom- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks :)

Please only select one checkbox as Type of change. This is also described in the paragraph. Probably you missed it.

@Noltari
Copy link
Contributor Author

Noltari commented Jun 8, 2023

Changes look good to me. Thanks :)

Please only select one checkbox as Type of change. This is also described in the paragraph. Probably you missed it.

Actually I didn't miss it, but since it's fixing a bug and also updating a dependency...

BTW, I've already done this multiple times in the past and none complained until now...
#94100

@freeDom-
Copy link
Contributor

freeDom- commented Jun 8, 2023

Changes look good to me. Thanks :)
Please only select one checkbox as Type of change. This is also described in the paragraph. Probably you missed it.

Actually I didn't miss it, but since it's fixing a bug and also updating a dependency...

BTW, I've already done this multiple times in the past and none complained until now... #94100

That doesn't mean that it is correct ;). When creating the PR it states clearly that you must and may only select one option. Why this is the case I do not know - maybe someone else can help out here. I was told this as well, because I did exactly the same a while ago, since my PR was also a dependency upgrade and bug fix....

Thanks for changing 👍

@frenck frenck added this to the 2023.6.1 milestone Jun 8, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Noltari 👍

../Frenck

@frenck frenck merged commit 081bc47 into home-assistant:dev Jun 8, 2023
52 checks passed
@Noltari Noltari deleted the airzone-cloud-v0.1.8 branch June 8, 2023 09:53
balloob pushed a commit that referenced this pull request Jun 8, 2023
@balloob balloob mentioned this pull request Jun 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected error fetching airzone_cloud data: 'stat_ssid'
4 participants