Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pulsectl to 23.5.2 #94227

Merged
merged 1 commit into from Jun 8, 2023
Merged

Conversation

chatziko
Copy link
Contributor

@chatziko chatziko commented Jun 8, 2023

Proposed change

This PR bumps pulsectl to 23.5.2 for pulseaudio_loopback. Without it pulseaudio_loopback does not work in 2023.6 (likely an issue with python 3.11).

Package changelog: https://github.com/mk-fg/python-pulse-control/blob/master/CHANGES.rst

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • [] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@freeDom- freeDom- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run python3 -m script.gen_requirements_all to update requirements text file as well.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! As per comment above, the CI is currently failing. Please run the listed command.

Also, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

(See also the "If the code communicates with devices, web services, or third-party tools:" section of the PR template you've filled out).

Thanks already! 👍

@home-assistant home-assistant bot marked this pull request as draft June 8, 2023 09:15
@home-assistant
Copy link

home-assistant bot commented Jun 8, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Fixes pulseaudio_loopback not starting in 2023.6.
@chatziko chatziko marked this pull request as ready for review June 8, 2023 09:35
@home-assistant home-assistant bot requested review from freeDom- and frenck June 8, 2023 09:35
Copy link
Contributor

@freeDom- freeDom- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@frenck frenck added this to the 2023.6.1 milestone Jun 8, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chatziko 👍

../Frenck

@frenck frenck merged commit 2f2504b into home-assistant:dev Jun 8, 2023
51 of 52 checks passed
balloob pushed a commit that referenced this pull request Jun 8, 2023
@balloob balloob mentioned this pull request Jun 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants