Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohomekit to 2.6.5 (fixes python 3.11 regression) #94245

Merged
merged 1 commit into from Jun 8, 2023

Conversation

Jc2k
Copy link
Member

@Jc2k Jc2k commented Jun 8, 2023

Proposed change

Python 3.11 changed Enum behaviour, and a side effect of this was aiohomekit started leaking a enum name into its HAP requests instead of the actual content type. This was fixed in aiohomekit 2.6.5.

As per Jc2k/aiohomekit#294, @bdraco has tested this with ~50 devices as well.

Jc2k/aiohomekit@2.6.4...2.6.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 8, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit_controller) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit_controller can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homekit_controller Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@Jc2k Jc2k added this to the 2023.6.1 milestone Jun 8, 2023
@Jc2k Jc2k merged commit 77badaf into home-assistant:dev Jun 8, 2023
52 checks passed
@Jc2k Jc2k deleted the homekit_controller_94184 branch June 8, 2023 13:10
@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Jun 8, 2023

thanks Jc2k and Nick!
hope this indeed fixes it, can we expect this to land in a .1 release?

@frenck
Copy link
Member

frenck commented Jun 8, 2023

@Mariusthvdb

CleanShot 2023-06-08 at 16 12 56

CleanShot 2023-06-08 at 16 12 20

@Mariusthvdb
Copy link
Contributor

Mariusthvdb commented Jun 8, 2023

... cool, and sorry for not spotting that.... 😊
appreciated!

@frenck
Copy link
Member

frenck commented Jun 8, 2023

no problem :)

@Jc2k
Copy link
Member Author

Jc2k commented Jun 8, 2023

@Mariusthvdb you had the additional weirdness where curl was not able to connect, but hopefully that was just a mistake with curl syntax rather than an indicator of a separate problem with your device.

@balloob balloob mentioned this pull request Jun 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homekit controller Somfy tahoma switch not working anymore after 2023.6.0 update
5 participants