Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value when logger used #94269

Merged
merged 1 commit into from Jun 8, 2023
Merged

Fix default value when logger used #94269

merged 1 commit into from Jun 8, 2023

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 8, 2023

Breaking change

Proposed change

In #80033 logger got added to default config. We had a lengthy discussion and updated logger to not touch the default log level unless default was specified. PR #65158 added a websocket endpoint to the logger was opened before #80033 but was merged afterwards, and added back a default set to debug. This default however was only processed if a user had logger: in their configuration.yaml.

This PR addresses this and we no longer set a default log level when logger integration is loaded.

CC @bdraco

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob balloob requested a review from a team as a code owner June 8, 2023 15:29
@home-assistant
Copy link

home-assistant bot commented Jun 8, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (logger) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of logger can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign logger Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@balloob balloob added this to the 2023.6.1 milestone Jun 8, 2023
@balloob balloob merged commit 76535d3 into dev Jun 8, 2023
47 checks passed
@balloob balloob deleted the fix-default-logger-value branch June 8, 2023 16:00
@bdraco
Copy link
Member

bdraco commented Jun 8, 2023

Thanks!

balloob added a commit that referenced this pull request Jun 8, 2023
@balloob balloob mentioned this pull request Jun 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants