Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repair issue about no yaml for config entries #94271

Merged
merged 2 commits into from Jun 8, 2023
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 8, 2023

Proposed change

In #93807 we added a repair issue if someone specifies an integration in YAML while that is not supported. In #93854 this was expanded to add a link to set up a config entry for the integration. However, that link relied on a description placeholder that was not set.

This PR adds the description placeholder.

image

Also fixes:

  • use of my links
  • incorrect issue key (conflicting with the other existing case)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck requested a review from a team as a code owner June 8, 2023 15:47
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Jun 8, 2023
@frenck frenck added this to the 2023.6.1 milestone Jun 8, 2023
@frenck frenck merged commit 6db1fbf into dev Jun 8, 2023
48 checks passed
@frenck frenck deleted the frenck-2023-0863 branch June 8, 2023 16:22
@balloob balloob mentioned this pull request Jun 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants