Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump elkm1-lib to 2.2.5 #94296

Merged
merged 4 commits into from Jun 12, 2023
Merged

Bump elkm1-lib to 2.2.5 #94296

merged 4 commits into from Jun 12, 2023

Conversation

gwww
Copy link
Contributor

@gwww gwww commented Jun 8, 2023

Proposed change

Bump elkm1-lib to fix issue. gwww/elkm1@2.2.2...2.2.5

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 8, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (elkm1) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of elkm1 can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign elkm1 Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco changed the title Bump elkm1-lib to 2.2.3 Bump elkm1-lib to 2.2.4 Jun 10, 2023
@bdraco bdraco added this to the 2023.6.2 milestone Jun 10, 2023
@gwww
Copy link
Contributor Author

gwww commented Jun 10, 2023

You are quick! Dang json language server formats different than HA likes -- bit me too many times, now disabled it!

@gwww gwww changed the title Bump elkm1-lib to 2.2.4 Bump elkm1-lib to 2.2.5 Jun 12, 2023
@bdraco bdraco marked this pull request as ready for review June 12, 2023 01:24
@bdraco bdraco merged commit acaa9ef into home-assistant:dev Jun 12, 2023
51 checks passed
@bdraco
Copy link
Member

bdraco commented Jun 12, 2023

Thanks @gwww

@gwww
Copy link
Contributor Author

gwww commented Jun 12, 2023

Thanks @bdraco! I wouldn’t have got there without your help!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
@gwww gwww deleted the elk-bump branch March 24, 2024 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elk M1 no longer integrating after upgrade to Core 2023.6
3 participants