Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Reolink update entity #94323

Merged
merged 8 commits into from Jun 28, 2023
Merged

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Jun 9, 2023

Breaking change

Proposed change

Add release notes and firmware file download link to the update entity.

Requires the reolink-aio version bump PR #94259 to be merged first.

afbeelding

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG marked this pull request as ready for review June 9, 2023 16:01
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 21, 2023
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 24, 2023 11:08
@starkillerOG starkillerOG marked this pull request as ready for review June 26, 2023 14:37
@home-assistant home-assistant bot marked this pull request as draft June 27, 2023 17:07
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Jun 27, 2023
@starkillerOG starkillerOG marked this pull request as ready for review June 27, 2023 20:50
@home-assistant home-assistant bot requested a review from frenck June 27, 2023 20:50
@frenck frenck requested a review from c0ffeeca7 June 27, 2023 20:55
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a suggestion for the text. But I'm not sure if this works with the string formatting / still has the line breaks in the right place.

homeassistant/components/reolink/update.py Outdated Show resolved Hide resolved
homeassistant/components/reolink/update.py Outdated Show resolved Hide resolved
homeassistant/components/reolink/update.py Outdated Show resolved Hide resolved
starkillerOG and others added 3 commits June 28, 2023 09:21
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @starkillerOG 👍

@starkillerOG
Copy link
Contributor Author

@c0ffeeca7 thank you for the text improvement!
Formatting looks good to me:
afbeelding

@frenck do you also approve?

@frenck
Copy link
Member

frenck commented Jun 28, 2023

@frenck do you also approve?

The bot has assigned me. I've asked you quite a few times now to stop pinging people for this.

../Frenck

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

../Frenck

@frenck frenck dismissed gjohansson-ST’s stale review June 28, 2023 11:32

Comment addressed.

@frenck frenck merged commit ee4459f into home-assistant:dev Jun 28, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants