Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated asyncio.wait use with coroutines #94371

Merged

Conversation

syssi
Copy link
Member

@syssi syssi commented Jun 9, 2023

Proposed change

Fixes #94218

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happened in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 9, 2023

Hey there @rytilahti, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of xiaomi_miio can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign xiaomi_miio Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@starkillerOG starkillerOG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using asyncio.create_task instead of hass.async_create_task?

@syssi
Copy link
Member Author

syssi commented Jun 11, 2023

Just for consistency. Is there a difference?

@starkillerOG
Copy link
Contributor

I think hass.async_create_task makes sure there is a hard refrence to the task such that it does not get cleaned by the garbage collector which can cause issues.

But I am not sure.

I was thinking they probably did not make hass.async_create_task for nothing.

@starkillerOG
Copy link
Contributor

Since the task is awaited directly afterwards I think this is fine.

Copy link
Contributor

@starkillerOG starkillerOG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once black is fixed I think this is good to go

@syssi syssi marked this pull request as ready for review June 11, 2023 15:19
@syssi syssi requested a review from rytilahti as a code owner June 11, 2023 15:19
@syssi syssi force-pushed the fix-asyncio-wait-with-coroutines branch from 6e5987e to cecc3b8 Compare June 11, 2023 15:20
@starkillerOG starkillerOG merged commit 2d62735 into home-assistant:dev Jun 11, 2023
23 checks passed
ocalvo pushed a commit to ocalvo/home-assistant that referenced this pull request Jun 11, 2023
@frenck frenck added this to the 2023.6.2 milestone Jun 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xiaomi_miio got broken in 2023.6.0
5 participants