Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinator to QNAP #94413

Merged
merged 36 commits into from Jun 14, 2023
Merged

Add coordinator to QNAP #94413

merged 36 commits into from Jun 14, 2023

Conversation

disforw
Copy link
Contributor

@disforw disforw commented Jun 10, 2023

Breaking change

Proposed change

Moving QNAP integration to coordinator in prep for config_flow

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@disforw
Copy link
Contributor Author

disforw commented Jun 10, 2023

@dgomes would you mind formatting me here? I’m just going to power through this quickly.

@dgomes
Copy link
Contributor

dgomes commented Jun 11, 2023

Working with the web interface alone without testing it properly will not get this PR through :(

homeassistant/components/qnap/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/qnap/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/qnap/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/qnap/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/qnap/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/qnap/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/qnap/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/qnap/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/qnap/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/qnap/coordinator.py Outdated Show resolved Hide resolved
@epenet
Copy link
Contributor

epenet commented Jun 12, 2023

Like @dgomes said, you should really setup a dev environment... it's not complicated and it will make it easier no only for the reviewers but also for yourself.

disforw and others added 11 commits June 12, 2023 07:33
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@disforw
Copy link
Contributor Author

disforw commented Jun 12, 2023

I already began working on a brand new dev environment for this, I now see it’s necessary.
Thank you so much for this work, it was extremely helpful!

@disforw disforw marked this pull request as ready for review June 13, 2023 02:00
@disforw
Copy link
Contributor Author

disforw commented Jun 13, 2023

Ok I think this one is ready

homeassistant/components/qnap/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/qnap/sensor.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 13, 2023 06:28
disforw and others added 6 commits June 13, 2023 07:23
@disforw disforw marked this pull request as ready for review June 13, 2023 12:41
@home-assistant home-assistant bot requested a review from epenet June 13, 2023 12:41
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last small thing, regarding type hints.

Can you please also explicitely confirm that the code has been tested against a real QNAP server?

homeassistant/components/qnap/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 13, 2023 13:00
disforw and others added 2 commits June 13, 2023 09:40
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@disforw
Copy link
Contributor Author

disforw commented Jun 13, 2023

Tested on QNAP server, working perfectly!

@disforw disforw marked this pull request as ready for review June 13, 2023 13:49
@home-assistant home-assistant bot requested a review from epenet June 13, 2023 13:50
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@dgomes / @starkillerOG anything to add?

Copy link
Contributor

@starkillerOG starkillerOG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
One small comment related to the config flow PR.

homeassistant/components/qnap/sensor.py Show resolved Hide resolved
@disforw disforw mentioned this pull request Jun 14, 2023
19 tasks
Copy link
Contributor

@dgomes dgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS-251+

@epenet epenet merged commit a79e37c into home-assistant:dev Jun 14, 2023
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants