Fix: Xiaomi Miio Fan, delay off countdown unit conversion

[golles]

Breaking change

The state of number.<device_name>_delay_off_countdown was wrongly converted to seconds (multiplied by 60), this change corrects that.

Proposed change

Fix bug that Xiaomi Miio Fan, delay off countdown unit conversion is wrong minutes/seconds

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Xiaomi Miio Fan, delay off countdown wrong unit of time #91824
• The unit is set internally set in minutes, see https://github.com/home-assistant/core/blob/dev/homeassistant/components/xiaomi_miio/number.py#L201
• When submitting, it was converted to seconds
• Checked the library to verify it is indeed minutes that need to be provided: https://github.com/rytilahti/python-miio/blob/0.5.12/miio/integrations/fan/dmaker/fan_miot.py#L371-L381

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @rytilahti, @syssi, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of xiaomi_miio can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign xiaomi_miio Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[syssi]

AFAIK some miIO devices expect minutes here and others seconds. Because of the inconsistent API / abstraction this isn't trivial to solve unfortunately.

[golles]

[golles]

AFAIK some miIO devices expect minutes here and others seconds. Because of the inconsistent API / abstraction this isn't trivial to solve unfortunately.

It looks like the only device that is acting differently is the FanP5
The property is in seconds https://github.com/rytilahti/python-miio/blob/0.5.12/miio/integrations/fan/dmaker/fan.py#L70-L73
And for setting it is in minutes https://github.com/rytilahti/python-miio/blob/0.5.12/miio/integrations/fan/dmaker/fan.py#L224-L234

[golles]

@syssi what if I change it to

    async def async_set_delay_off_countdown(self, delay_off_countdown: int) -> bool:
        """Set the delay off countdown."""
        return await self._try_command(
            "Setting delay off miio device failed.",
            self._device.delay_off,
            delay_off_countdown * 60
            if self._model == MODEL_FAN_P5
            else delay_off_countdown,
        )

[syssi]

It looks like the only device that is acting differently is the FanP5

Thanks for looking this up!! In this case we should give it a try! Please mark the change as breaking so the users has a chance to be informed.

[syssi]

The issue/inconsistency should be fixed at the underlying library (python-miio). We shouldn't introduce workarounds here.

[syssi]

This is good to go!

[golles]

The issue/inconsistency should be fixed at the underlying library (python-miio). We shouldn't introduce workarounds here.

I agree,

It looks like the only device that is acting differently is the FanP5

Thanks for looking this up!! In this case we should give it a try! Please mark the change as breaking so the users has a chance to be informed.

Done, let me know if you agree with what I wrote.