-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle LastFM unavailable #94456
Merged
Merged
Handle LastFM unavailable #94456
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
a867651
Handle LastFM unavailable
joostlek fcab484
Handle LastFM unavailable
joostlek 3ecb6eb
Handle LastFM unavailable
joostlek 9f13b8c
Fix feedback
joostlek 7f99fb0
Add tests
joostlek 8acd58c
Add tests
joostlek 82130b7
Merge branch 'dev' into lastfm_unavailable
joostlek a03dc9a
Add tests
joostlek a84374b
Add tests
joostlek 41f99b8
Add tests
joostlek 9109330
Merge branch 'dev' into lastfm_unavailable
joostlek 63bd5b8
Make update partially fail
joostlek d95bc23
Make update partially fail
joostlek fe4cbf8
Make update completely fail
joostlek de10463
Make update completely fail
joostlek 5dbf95a
Make update completely fail
joostlek 86cc38e
Cleanup tests
joostlek b38d503
Move stuff out of try block
joostlek 25f4995
Fix feedback
joostlek d88c837
Fix tests
joostlek 1bce3fc
Fix unavailable
joostlek File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could rethrow this with some kind of HA core error? I think it would better indicate to HA that there's a problem and I think it'll do retries for us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we used get_playcount to verify a user still exists. So if a user got deleted it would become unavailable. But now I want to handle what happens if LastFM is having connection issues. So throwing a Home Assistant error wouldn't be fitting as it's an error originating from LastFM