Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button platform to Dremel 3D printer #94517

Merged
merged 3 commits into from Jun 27, 2023
Merged

Add button platform to Dremel 3D printer #94517

merged 3 commits into from Jun 27, 2023

Conversation

tkdrob
Copy link
Contributor

@tkdrob tkdrob commented Jun 13, 2023 •
edited

Proposed change

Add button platform to Dremel 3D printer

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@tkdrob tkdrob mentioned this pull request Jun 13, 2023
Merged
8 tasks
Noltari
Noltari approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@Noltari Noltari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emontnemery
emontnemery previously requested changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think the names should go in strings.json

homeassistant/components/dremel_3d_printer/button.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 13, 2023 15:49
@tkdrob tkdrob marked this pull request as ready for review June 18, 2023 03:11
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 21, 2023
frenck
frenck approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tkdrob 👍

../Frenck

@frenck frenck dismissed emontnemery’s stale review June 27, 2023 15:44

Comment addressed

@frenck frenck merged commit cd26de7 into home-assistant:dev Jun 27, 2023
23 checks passed
@tkdrob tkdrob deleted the dremel_button branch June 27, 2023 18:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@Noltari Noltari Noltari approved these changes

@emontnemery emontnemery Awaiting requested review from emontnemery

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: dremel_3d_printer new-feature new-platform Quality Scale: No score smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tkdrob @frenck @Noltari @emontnemery