Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Insteon events correctly #94549

Merged
merged 2 commits into from Jun 16, 2023
Merged

Conversation

teharris1
Copy link
Contributor

Proposed change

Insteon event handler was specific to On/Off events. Other events have a different signature and the event handler needs to be generalized.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@teharris1 teharris1 changed the title Handle Insteon events curretly Handle Insteon events correctly Jun 13, 2023
@teharris1 teharris1 added this to the 2023.6.3 milestone Jun 15, 2023
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @teharris1 👍

@emontnemery emontnemery merged commit ea0e1c5 into home-assistant:dev Jun 16, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2023
@teharris1 teharris1 deleted the fix_noise branch January 3, 2024 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyinsteon.utils sendMessage Missing Data
3 participants