Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Dremel 3D Printer sensors #94552

Merged
merged 3 commits into from Jun 26, 2023
Merged

Conversation

tkdrob
Copy link
Contributor

@tkdrob tkdrob commented Jun 13, 2023

Proposed change

No breaking change as the integration is only in dev.

Time deltas were using the wrong operator (showed a time in the past for something that should be in the future).
Renamed remaining time to completion time. This seems to make more sense as the UI displays it as for example (in 30 minutes).
Adjusted elapsed time unit of measurement and device class. This will now show for example (30 min) which seems more natural.
Same as above was done with Estimated total time which is not a point in time but a duration.
Hours used looked weird to me displaying as 36:00:00 which only displays hours and never minutes or seconds. So this will now show as 36 hr.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 21, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tkdrob 👍

../Frenck

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! There is a merge conflict, can you take a look?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft June 26, 2023 16:11
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Jun 26, 2023
@frenck
Copy link
Member

frenck commented Jun 26, 2023

@tkdrob Ready to go now? As in, still draft for a reason?

@tkdrob tkdrob marked this pull request as ready for review June 26, 2023 20:36
@home-assistant home-assistant bot requested a review from frenck June 26, 2023 20:36
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tkdrob 👍

@frenck frenck merged commit c677592 into home-assistant:dev Jun 26, 2023
23 checks passed
@tkdrob tkdrob deleted the dremel_sensor_tweak branch June 26, 2023 20:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants