-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak Dremel 3D Printer sensors #94552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tkdrob 👍
../Frenck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! There is a merge conflict, can you take a look?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@tkdrob Ready to go now? As in, still draft for a reason? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tkdrob 👍
Proposed change
No breaking change as the integration is only in dev.
Time deltas were using the wrong operator (showed a time in the past for something that should be in the future).
Renamed remaining time to completion time. This seems to make more sense as the UI displays it as for example (in 30 minutes).
Adjusted elapsed time unit of measurement and device class. This will now show for example (30 min) which seems more natural.
Same as above was done with Estimated total time which is not a point in time but a duration.
Hours used looked weird to me displaying as 36:00:00 which only displays hours and never minutes or seconds. So this will now show as 36 hr.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: