Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyboard_remote for python 3.11 #94570

Merged
merged 8 commits into from Jun 14, 2023
Merged

Fix keyboard_remote for python 3.11 #94570

merged 8 commits into from Jun 14, 2023

Conversation

lanrat
Copy link
Contributor

@lanrat lanrat commented Jun 14, 2023 •
edited by MartinHjelmare

Breaking change

Proposed change

With the upgrade to Python 3.11 the keyboard_remote integration broke.

This PR changes the underlying library from aionotify which lacked python 3.11 support to asyncinotify which is fully supported.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bendavid, mind taking a look at this pull request as it has been labeled with an integration (keyboard_remote) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of keyboard_remote can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign keyboard_remote Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@MartinHjelmare MartinHjelmare changed the title fix keyboard_remote for python 3.11 Fix keyboard_remote for python 3.11 Jun 14, 2023
MartinHjelmare
MartinHjelmare requested changes Jun 14, 2023
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

homeassistant/components/keyboard_remote/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/keyboard_remote/__init__.py Show resolved Hide resolved
homeassistant/components/keyboard_remote/__init__.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 14, 2023 05:58
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@lanrat lanrat marked this pull request as ready for review June 14, 2023 06:13
@cobcoben
Copy link

cobcoben commented Jun 14, 2023 •
edited

Hi
Thanks for fixing it.
But I can't find the folders and files to modify....
Thanks for your help!

ssh terminal:
[core-ssh /]$ find / -type d -name components /config/esphome/.esphome/build/esp32-bluetooth-proxy-4cb664/src/esphome/components [core-ssh /]$ find / -type f -name manifest.json /config/custom_components/protexiom/manifest.json /config/custom_components/ipx800v4/manifest.json /config/custom_components/ble_monitor/manifest.json /config/custom_components/sonoff/manifest.json /config/custom_components/shelly/manifest.json /config/custom_components/browser_mod/manifest.json /config/custom_components/hacs/hacs_frontend_experimental/manifest.json /config/custom_components/hacs/hacs_frontend/manifest.json /config/custom_components/hacs/manifest.json /config/custom_components/plant/manifest.json /config/custom_components/ui_lovelace_minimalist/manifest.json /config/custom_components/ics_calendar/manifest.json [core-ssh /]$ find / -type d -name keyboard_remote [core-ssh /]$ find /-type d -name ".*" find: /-type: No such file or directory find: d: No such file or directory [core-ssh /]$ find / -type d -name ".*" /tmp/.bashio /run/service/.s6-svscan /run/s6/basedir/run-image/service/.s6-svscan /config/.cloud /config/esphome/.esphome /config/esphome/.esphome/packages/f8744889/.github /config/esphome/.esphome/packages/f8744889/.git /config/.storage /config/custom_components/shelly/.translations /data/.ssh

@frenck
Copy link
Member

frenck commented Jun 14, 2023

@cobcoben This is not really the place for getting support on how to run custom components. Please use our community forums for such questions instead.

Thanks! 👍

../Frenck

@cobcoben
Copy link

Yes, you're right; I was too fast and went to the wrong place!
Sorry!
(not very familiar with github)

@lanrat
Copy link
Contributor Author

lanrat commented Jun 14, 2023

@MartinHjelmare can you approve the last changes made?

The only test that fails seems to be from a dependency unrelated to this integration and PR.

MartinHjelmare
MartinHjelmare approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Our infrastructure will build wheels for evdev after this PR is merged.

@MartinHjelmare MartinHjelmare added this to the 2023.6.2 milestone Jun 14, 2023
@MartinHjelmare MartinHjelmare merged commit e998320 into home-assistant:dev Jun 14, 2023
50 of 51 checks passed
balloob pushed a commit that referenced this pull request Jun 15, 2023
@lanrat @MartinHjelmare @balloob
Fix keyboard_remote for python 3.11 (#94570)
d28d909 
* started work to update keyboard_remote to work with python 3.11

* updated function names

* all checks pass

* fixed asyncio for python 3.11

* cleanup

* Update homeassistant/components/keyboard_remote/__init__.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* Update __init__.py

added:
from __future__ import annotations

* Fix typing

---------

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@balloob balloob mentioned this pull request Jun 15, 2023
Merged
@lanrat lanrat deleted the keyboard_Remote_py3.11 branch June 15, 2023 20:44
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency integration: keyboard_remote Quality Scale: No score
Projects
None yet
Milestone
2023.6.2
Development

Successfully merging this pull request may close these issues.

Keyboard Remote not working - restart impossible after update to 2023.6.0
5 participants
@lanrat @cobcoben @frenck @MartinHjelmare @balloob