Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed recovery in ipp #94573

Merged
merged 1 commit into from Jun 14, 2023
Merged

Fix failed recovery in ipp #94573

merged 1 commit into from Jun 14, 2023

Conversation

ctalkington
Copy link
Contributor

Breaking change

Proposed change

There have been numerous reports of IPP failing to recover from failed connection during startup to the device sleeping/shutoff and not re-establishing when it eventually wakes. This seems to have started only due to changes/optimizations to core and not to ipp integration. Roku integration also shares similar setup code and sees same behavior.

research by multiple parties seems to point to a race on unload due to the way coordinator was trying to be reused to pre-emptively avoid errors in #44413 which seems might race more often now since #91748

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@ctalkington ctalkington marked this pull request as ready for review June 14, 2023 06:14
@ctalkington ctalkington added this to the 2023.6.2 milestone Jun 14, 2023
@ctalkington ctalkington requested a review from bdraco June 14, 2023 06:14
@bdraco bdraco merged commit 6a75f69 into dev Jun 14, 2023
23 checks passed
@bdraco bdraco deleted the ctalkington-ipp-fix branch June 14, 2023 07:07
balloob pushed a commit that referenced this pull request Jun 15, 2023
@balloob balloob mentioned this pull request Jun 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.