Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum typing_extensions to 4.6.3 #94587

Merged
merged 1 commit into from Jun 15, 2023

Conversation

freeDom-
Copy link
Contributor

@freeDom- freeDom- commented Jun 14, 2023

Breaking change

Proposed change

Bump typing extensions to 4.6.3 or greater to fix a problem with HA not starting.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Jun 14, 2023
@freeDom- freeDom- marked this pull request as ready for review June 14, 2023 11:42
@freeDom- freeDom- requested a review from a team as a code owner June 14, 2023 11:42
@freeDom- freeDom- marked this pull request as draft June 14, 2023 12:35
@freeDom- freeDom- marked this pull request as ready for review June 14, 2023 22:44
@freeDom- freeDom- closed this Jun 14, 2023
@freeDom- freeDom- reopened this Jun 14, 2023
@epenet epenet changed the title Bump typing_extensions Bump minimum typing_extensions to 4.6.3 Jun 15, 2023
@frenck frenck added this to the 2023.6.3 milestone Jun 15, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @freeDom- 👍

../Frenck

@frenck frenck merged commit 64d914d into home-assistant:dev Jun 15, 2023
94 of 95 checks passed
@freeDom- freeDom- deleted the bump-typing-extensions branch June 15, 2023 10:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 2023.6 does not start
2 participants