Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config Flow to EmonCMS #94593

Closed

Conversation

ArnyminerZ
Copy link

Breaking change

Existing YAML configuration must be migrated to config flow.

Proposed change

Add config flow functionality to EmonCMS, and also group entities by its server.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@home-assistant home-assistant bot added cla-signed config-flow This integration migrates to the UI by adding a config flow integration: emoncms new-feature Quality Scale: No score labels Jun 14, 2023
@home-assistant
Copy link

Hey there @borpin, mind taking a look at this pull request as it has been labeled with an integration (emoncms) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of emoncms can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign emoncms Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@MartinHjelmare MartinHjelmare changed the title Added Config Flow to EmonCMS Add Config Flow to EmonCMS Jun 14, 2023
@epenet
Copy link
Contributor

epenet commented Jun 15, 2023

This PR is way bigger than it needs to be, and will be very difficult to review as it is.
It is missing tests - tests are compulsory for config flow.
It also seems to be missing the migration/deprecation from YAML.

I suggest that you keep this in draft and create preliminary PR for all refactoring that is not directly linked to the config flow.

Copy link

@waako waako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment on the python code I'm afraid, but looks promising.
Just confused about the change to cloud_polling.

There does appear to be overlap with #86840 but assume this PR supersedes anything in that one ?

"documentation": "https://www.home-assistant.io/integrations/emoncms",
"iot_class": "local_polling"
"integration_type": "hub",
"iot_class": "cloud_polling",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is only relevant if using emoncms.org.
Majority of users interface with a local instance, it does not require internet access.

"config_flow": false,
"iot_class": "local_polling",
"config_flow": true,
"iot_class": "cloud_polling",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same query as in the manifest.json.
By default EmonCMS would be used with local hardware/server, so local_polling.
Similar to MQTT, which mostly is local, but can be used with a cloud service.

Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 18, 2023
@borpin
Copy link

borpin commented Nov 18, 2023

Hopefully soon.

@github-actions github-actions bot removed the stale label Nov 18, 2023
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Jan 17, 2024
@github-actions github-actions bot closed this Jan 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants