New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Config Flow to EmonCMS #94593
Add Config Flow to EmonCMS #94593
Conversation
Signed-off-by: Arnau Mora <arnyminerz@proton.me>
Hey there @borpin, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This PR is way bigger than it needs to be, and will be very difficult to review as it is. I suggest that you keep this in draft and create preliminary PR for all refactoring that is not directly linked to the config flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't comment on the python code I'm afraid, but looks promising.
Just confused about the change to cloud_polling
.
There does appear to be overlap with #86840 but assume this PR supersedes anything in that one ?
"documentation": "https://www.home-assistant.io/integrations/emoncms", | ||
"iot_class": "local_polling" | ||
"integration_type": "hub", | ||
"iot_class": "cloud_polling", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is only relevant if using emoncms.org.
Majority of users interface with a local instance, it does not require internet access.
"config_flow": false, | ||
"iot_class": "local_polling", | ||
"config_flow": true, | ||
"iot_class": "cloud_polling", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same query as in the manifest.json.
By default EmonCMS would be used with local hardware/server, so local_polling.
Similar to MQTT, which mostly is local, but can be used with a cloud service.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Hopefully soon. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Breaking change
Existing YAML configuration must be migrated to config flow.
Proposed change
Add config flow functionality to EmonCMS, and also group entities by its server.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: