Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glances raid plugin data #94597

Merged
merged 6 commits into from Jun 23, 2023

Conversation

freeDom-
Copy link
Contributor

@freeDom- freeDom- commented Jun 14, 2023

Breaking change

Proposed change

Add safe navigation to SENSOR_TYPES dictionary to prevent glances from crashing if api sends more sensors than setup in integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration (glances) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of glances can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign glances Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this PR in two:

  • One which fixes the bug
  • One which adds new sensors

@home-assistant home-assistant bot marked this pull request as draft June 16, 2023 07:24
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MartinHjelmare MartinHjelmare changed the title Fix-raid-plugin-data-for-glances Fix glances raid plugin data Jun 16, 2023
@freeDom- freeDom- marked this pull request as ready for review June 16, 2023 09:13
@freeDom- freeDom- force-pushed the fix-raid-plugin-data-for-glances branch from 08d0357 to 754d5fd Compare June 16, 2023 09:14
@freeDom-
Copy link
Contributor Author

Removed additional sensors and only provided bugfix

homeassistant/components/glances/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/glances/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 22, 2023 06:23
freeDom- and others added 2 commits June 22, 2023 10:12
Make use of walrus operator

Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@freeDom-
Copy link
Contributor Author

@epenet Thanks for the review, included your changes. That walrus is very handy, but still quite new for me. Going to make use of it as much as possible in the future!

@freeDom- freeDom- marked this pull request as ready for review June 22, 2023 08:14
@home-assistant home-assistant bot requested a review from epenet June 22, 2023 08:14
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@emontnemery all good for you?

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @freeDom- 👍

../Frenck

@frenck frenck merged commit 239f5fe into home-assistant:dev Jun 23, 2023
23 checks passed
frenck pushed a commit that referenced this pull request Jun 23, 2023
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@frenck frenck mentioned this pull request Jun 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2023
@freeDom- freeDom- deleted the fix-raid-plugin-data-for-glances branch June 28, 2023 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glances integration fails completely due to raid plugin output
4 participants