New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix glances raid plugin data #94597
Fix glances raid plugin data #94597
Conversation
Hey there @engrbm87, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
5fd5774
to
8547222
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this PR in two:
- One which fixes the bug
- One which adds new sensors
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
08d0357
to
754d5fd
Compare
Removed additional sensors and only provided bugfix |
Make use of walrus operator Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@epenet Thanks for the review, included your changes. That walrus is very handy, but still quite new for me. Going to make use of it as much as possible in the future! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@emontnemery all good for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @freeDom- 👍
../Frenck
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Breaking change
Proposed change
Add safe navigation to SENSOR_TYPES dictionary to prevent glances from crashing if api sends more sensors than setup in integration.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: