Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove str as a valid HVACMode & HVACAction type #94644

Merged
merged 3 commits into from Jun 15, 2023
Merged

Remove str as a valid HVACMode & HVACAction type #94644

merged 3 commits into from Jun 15, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 15, 2023

Proposed change

All integrations have migrated to use the new HVACMode & HVACAction enum instead of strings for HAVC modes. Therefore, the string typing can be removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of climate can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign climate Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@frenck frenck changed the title Remove str as a valid HAVCMode type Remove str as a valid HVACMode & HVACAction type Jun 15, 2023
@frenck frenck mentioned this pull request Jun 15, 2023
20 tasks
@frenck frenck marked this pull request as ready for review June 15, 2023 13:28
@frenck frenck requested a review from a team as a code owner June 15, 2023 13:28
@frenck frenck marked this pull request as draft June 15, 2023 13:29
@frenck
Copy link
Member Author

frenck commented Jun 15, 2023

Manually rebased the PR to get rid of the merge that epenet did.

Ref: https://developers.home-assistant.io/docs/development_catching_up

@frenck frenck marked this pull request as ready for review June 15, 2023 17:38
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epenet epenet merged commit 21bdcd6 into dev Jun 15, 2023
51 checks passed
@epenet epenet deleted the frenck-2023-0887 branch June 15, 2023 18:16
@frenck
Copy link
Member Author

frenck commented Jun 15, 2023

Thanks, @epenet 👍

../Frenck

@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants