New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bluetooth tracker asyncio usage #94695
Conversation
It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
"requirements": ["bt-proximity==0.2.1", "git+https://github.com/pybluez/pybluez.git@master#pybluez"], | ||
"version": "1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't accept requirements that aren't packaged releases.
I suggest splitting this PR so the device tracker change can be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I expected that and removed that one commit.
Do you know if, besides of HACS or waiting and praying for the owner of PyBluez releasing another official version, there is anything that can be done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fork PyBluez and create a new GitHub org to maintain it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are interested in maintaining it, I would try to reach out to the existing repo owners first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well ok. I'm not really interested in maintaining it (there are already new maintainers), mostly because its not my main language/environment. Just saw (like some others), that it got updated since the last release of 0.23 in 2019 and is even compatible to Python 3.11. sadly the PyPi release is kinda stale since 2021, because the new maintainers on GitHub dont have access to the PyPi account for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like its a fragmented mess https://pypi.org/search/?q=pybluez with no fork clearly alive or published a release in the last 6 months
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see above
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
fixes the error "Passing coroutines is forbidden, use tasks explicitly", caused by passing an async function into asyncio.wait directly instead of creating a task for it.
Please update the proposed change text to reflect what this PR does |
Breaking change
Proposed change
This PR only fixes the compatibility of the bluetooth_tracker component with Python 3.11, by correcting the usage of asyncio.wait(). As its not allowed to pass coroutines into it anymore, therefore a task needs to be created.
Beware, this PR does not fix the requirement of PyBluez 0.22 and its setup problem.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: