Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turning Airzone slave zones on with any HVAC mode #94721

Merged
merged 1 commit into from Jun 27, 2023

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Jun 16, 2023

Proposed change

If the user selects a different mode on a slave zone from the one selected on the master zone, it will raise an exception and it won't change the operation mode or turn it on.
Change this behaviour so that the exception will still be raised but the slave zone will be turned on and the hvac mode won't be changed. This allows commanding airzone slave zones from limited APIs like homekit.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

If the user selects a different mode on a slave zone from the one selected on
the master zone, it will raise an exception and it won't change the operation
mode or turn it on.
Change this behaviour so that the exception will still be raised but the slave
zone will be turned on and the hvac mode won't be changed.
This allows commanding airzone slave zones from limited APIs like homekit.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari changed the title airzone: climate: allow turning slave zone on with any hvac mode Allow turning Airzone slave zones on with any hvac mode Jun 16, 2023
@Noltari Noltari changed the title Allow turning Airzone slave zones on with any hvac mode Allow turning Airzone slave zones on with any HVAC mode Jun 16, 2023
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 21, 2023
@gjohansson-ST
Copy link
Member

Could we limit to only raise the issue if slave mode is actually different than master mode?
I think now it would raise the error even if they set same mode as already on the master?

@Noltari
Copy link
Contributor Author

Noltari commented Jun 22, 2023

Could we limit to only raise the issue if slave mode is actually different than master mode? I think now it would raise the error even if they set same mode as already on the master?

This is already handled here:

if mode != self.get_airzone_value(AZD_MODE):

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Noltari 👍

../Frenck

@frenck frenck merged commit 78380c0 into home-assistant:dev Jun 27, 2023
23 checks passed
shbatm pushed a commit to shbatm/home-assistant-core that referenced this pull request Jun 27, 2023
…nt#94721)

airzone: climate: allow turning slave zone on with any hvac mode

If the user selects a different mode on a slave zone from the one selected on
the master zone, it will raise an exception and it won't change the operation
mode or turn it on.
Change this behaviour so that the exception will still be raised but the slave
zone will be turned on and the hvac mode won't be changed.
This allows commanding airzone slave zones from limited APIs like homekit.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari deleted the airzone-climate-slave-exception branch June 28, 2023 06:55
@Noltari
Copy link
Contributor Author

Noltari commented Jun 28, 2023

Thanks Franck!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed has-tests integration: airzone Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I config cool mode at HomeKit but AirZone not started
3 participants