Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the device of the source entity in the helper entities for Riemann sum integral #94727

Merged
merged 3 commits into from Jun 22, 2023
Merged

Add the device of the source entity in the helper entities for Riemann sum integral #94727

merged 3 commits into from Jun 22, 2023

Conversation

dougiteixeira
Copy link
Contributor

@dougiteixeira dougiteixeira commented Jun 16, 2023 •
edited

Breaking change

None

Proposed change

Adds the device of the source entity in the helper entities for Riemann sum integral.

It was inspired by this comment (link).

Summary of the implementation in all helpers:

Helper Helper Domain PR
Derivative sensor derivative #94751
Integration - Riemann sum integral sensor integration #94727
Threshold Sensor threshold #94753
Utility Meter utility_meter #94734
Combine the state of several sensors min_max Can contain many source entities... how should it be handled?
Group group Can contain many source entities... how should it be handled?
Change device type of a switch switch_as_x Already implemented
Counter counter Does not come from a source entity
Toggle input_boolean Does not come from a source entity
Button input_button Does not come from a source entity
Date and/or time input_datetime Does not come from a source entity
Number input_number Does not come from a source entity
Dropdown input_select Does not come from a source entity
Text input_text Does not come from a source entity
Schedule schedule Does not come from a source entity
Timer timer Does not come from a source entity
Times of the Day Sensor tod Does not come from a source entity

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x ] The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • [x ] There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • [x ] The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@dougiteixeira
Adds the device of the original entity in the Integration helper sens…
0bc4c44 
…or - Riemann sum integral sensor (integration)
@home-assistant
Copy link

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (integration) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of integration can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign integration Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@dgomes
Copy link
Contributor

dgomes commented Jun 16, 2023

This is an interesting take, it would make the integration show under the source device...

@dougiteixeira
Copy link
Contributor Author

This is an interesting take, it would make the integration show under the source device...

It was inspired by this comment (link). I will work on the same for Utility Meter as well.

@dougiteixeira dougiteixeira changed the title Adds the device of the original entity in the Integration helper sensor - Riemann sum integral sensor (integration) Adds the device of the original entity in the helper entities Jun 16, 2023
@dougiteixeira dougiteixeira changed the title Adds the device of the original entity in the helper entities Adds the device of the original entity in the helper entities for Riemann sum integral Jun 16, 2023
dgomes
dgomes requested changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@dgomes dgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending addition of a test

@home-assistant home-assistant bot marked this pull request as draft June 16, 2023 22:06
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dougiteixeira
Copy link
Contributor Author

Pending addition of a test

Done!

@dougiteixeira dougiteixeira marked this pull request as ready for review June 16, 2023 23:08
@home-assistant home-assistant bot requested a review from dgomes June 16, 2023 23:08
This was referenced Jun 16, 2023
Merged
Merged
Merged
@MartinHjelmare MartinHjelmare changed the title Adds the device of the original entity in the helper entities for Riemann sum integral Add the device of the original entity in the helper entities for Riemann sum integral Jun 17, 2023
@dougiteixeira dougiteixeira changed the title Add the device of the original entity in the helper entities for Riemann sum integral Add the device of the source entity in the helper entities for Riemann sum integral Jun 17, 2023
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 21, 2023
frenck
frenck approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me @dougiteixeira 👍

../Frenck

@frenck frenck merged commit e5afff7 into home-assistant:dev Jun 22, 2023
23 checks passed
@dougiteixeira dougiteixeira deleted the helpers-device-integration branch June 22, 2023 22:10
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgomes dgomes dgomes approved these changes

@frenck frenck frenck approved these changes

Assignees

@dgomes dgomes

Labels
cla-signed integration: integration new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: internal smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dougiteixeira @dgomes @frenck