Bump python-vlc to 3.0.18122

[atudor2]

Proposed change

Bump version of python-vlc to 3.0.18122 to resolve #94720
Its a bit difficult for me to fully test the vlc integration locally, but tests pass and integration loads without error.

Changes: https://github.com/oaubert/python-vlc/commits/master/generated/3.0/vlc.py

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes VLC broken after 2023.6 update (cannot import name 'getargspec' from 'inspect') #94720
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[elupus]

Please add a link to changes in the new release of vlc plugin in the description.

[frenck]

I've marked this PR, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

[atudor2]

Apologies this fell off my todo list
These are generated bindings for libvlc and the news site hasn't been updated in 4 years.
Will the commit history on the generated file suffice?

[frenck]

@atudor2 How did you test this?

[atudor2]

@frenck unfortunately it's a bit difficult for me to fully test this integration locally, but I re-ran the unit tests and confirmed that the integration loads without error following the version bump

[frenck]

unfortunately it's a bit difficult for me to fully test this integration locally,

I will not be able to accept this PR without it being properly tested.

but I re-ran the unit tests and confirmed that the integration loads without error following the version bump

There are no unit tests for this integration....

[atudor2]

👍 I'll see if I can setup a venv instance and do further tests in the next few days.
I'll move this PR back to draft in the meantime

[ErikApption]

I applied this PR and changed homeassistant/components/vlc/manifest.json with the new version of python-vlc and I can confirm that the VLC integration works as expected. I am happy to run other tests, but not sure how a unit test would look like. This starts the VLC process and doesn't throw an error message on startup. This is caused by a Python 3.11 breaking change - without this PR, the VLC integration is completely broken.

[atudor2]

Thanks @ErikApption for the feedback
@frenck would this be sufficient for testing confirmation? Haven't had a chance yet to sit down and setup a core install yet

[ErikApption]

Thanks @ErikApption for the feedback @frenck would this be sufficient for testing confirmation? Haven't had a chance yet to sit down and setup a core install yet

Tested with 2023.8 and I can confirm this PR is necessary for the integration to work in 2023.8.

[atudor2]

I setup a core install and managed to test this my side as well playing, pausing and stopping an mp3 file - will reopen this PR for review

[ErikApption]

Anyway way to help on this one - I don't understand the risk of merging this one, as of today the VLC integration is just broken

[letshin]

I'm having the same issue too and I was using vlc-telnet without issues earlier.

[averater]

Very easy fix. Please merge!

[frenck]

Thanks, @atudor2 👍

../Frenck