Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Totalconnect BinarySensorDeviceClass logic #94772

Merged
merged 3 commits into from Jun 20, 2023

Conversation

austinmroczek
Copy link
Contributor

@austinmroczek austinmroczek commented Jun 17, 2023

Proposed change

Fix TotalConnect logic for setting BinarySensorDeviceClass for zones. Temperature zones will be handled as BinarySensorDeviceClass.PROBLEM because they alarm after reaching a threshold, and we have no way to determine if they are hot or cold sensors. All remaining zones will be assumed as BinarySensorDeviceClass.DOOR as was the previous logic.

Updates tests to include a temperature zone.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@austinmroczek austinmroczek marked this pull request as ready for review June 17, 2023 14:08
@gjohansson-ST gjohansson-ST added this to the 2023.6.3 milestone Jun 20, 2023
@gjohansson-ST gjohansson-ST merged commit 252c0e8 into home-assistant:dev Jun 20, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
@austinmroczek austinmroczek deleted the fix_tcc branch April 21, 2024 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TotalConnect integration fails after update to 2023.6.0
3 participants