Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that the MAC address that Fully Kiosk reported is usable #94887

Merged
merged 2 commits into from Jun 27, 2023
Merged

Verify that the MAC address that Fully Kiosk reported is usable #94887

merged 2 commits into from Jun 27, 2023

Conversation

haimgel
Copy link
Contributor

@haimgel haimgel commented Jun 19, 2023

Proposed change

On modern Android devices, the real MAC address is not exposed to applications, therefore, what Fully Kiosk reports is usually not usable as an ID.

On Android 13 (Samsung Galaxy Tab A7 Lite), Fully Kiosk reports "02:00:00:00:00:00" if "randomized MAC" is disabled, which leads to merging unrelated issues (similar issue to #77722).

This PR enhances MAC validation: if the second least significant bit is set in the MAC address, it's a locally administered MAC and should not be used as an identifier in HA.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

I contacted Fully Kiosk author about this issue, and here is what he said:

HA shouldn't treat any Mac address reported by Android as unique identifier. Every mac address on a modern Android device is fake and can change unpredictably unless you make device provisioning.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@haimgel haimgel requested a review from cgarwood as a code owner June 19, 2023 21:10
@home-assistant
Copy link

Hi @haimgel

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @cgarwood, mind taking a look at this pull request as it has been labeled with an integration (fully_kiosk) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fully_kiosk can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fully_kiosk Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@haimgel
Verify that the MAC address that Fully Kiosk reported is usable:
fff008b 
On modern Android devices, the real MAC address is not exposed to applications, therefore what Fully Kiosk reports is usually not usable as an ID.

On Android 13 (Samsung Galaxy Tab A7 Lite), Fully Kiosk reports "02:00:00:00:00:00" if "randomized MAC" is disabled, which leads to merging unrelated issues (similar issue to home-assistant#77722).

This commit enhances MAC validation: if the second least significant bit is set in the MAC address, it's a locally administered MAC, and it should not be used as an identifier in HA.
@haimgel haimgel force-pushed the fix/fully-kiosk-mac-addresses branch from bbcbd47 to fff008b Compare June 19, 2023 21:13
@haimgel haimgel force-pushed the fix/fully-kiosk-mac-addresses branch from 22f9d03 to 0302c78 Compare June 20, 2023 00:06
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 20, 2023
frenck
frenck approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @haimgel 👍

../Frenck

@frenck frenck merged commit 0c66cce into home-assistant:dev Jun 27, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@cgarwood cgarwood Awaiting requested review from cgarwood cgarwood is a code owner

Assignees

@cgarwood cgarwood

Labels
bugfix cla-signed has-tests integration: fully_kiosk Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haimgel @frenck @cgarwood