-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve websocket api coverage and typing #94891
Conversation
- Remove unreachable code
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, one comment, not use that helps much.
The rest LGTM,
Thnx @bdraco 👍
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
Adjusting back |
Thanks for the review |
The type hint was added so that the ignore could be removed. |
Unfortunately it trades one ignore for another so I took it back out
|
Messed around with this for a bit and since it's only going to get to that path on garbage input, the ignore makes sense here |
Not to go off topic, but is there a way for an average HAOS user to take advantage of these memory leak fixes in the frontend without setting up a dev environment? The memory leaks have made my system unstable. |
Proposed change
follow up to #94780
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: