Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve websocket api coverage and typing #94891

Merged
merged 6 commits into from Jun 20, 2023
Merged

Improve websocket api coverage and typing #94891

merged 6 commits into from Jun 20, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 20, 2023

Proposed change

follow up to #94780

  • Remove unreachable code

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (websocket_api) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of websocket_api can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign websocket_api Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco marked this pull request as ready for review June 20, 2023 03:27
@bdraco bdraco requested a review from a team as a code owner June 20, 2023 03:27
@bdraco bdraco mentioned this pull request Jun 20, 2023
20 tasks
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, one comment, not use that helps much.

The rest LGTM,
Thnx @bdraco 👍

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 20, 2023
Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>
@bdraco
Copy link
Member Author

bdraco commented Jun 20, 2023

Adjusting back

@bdraco
Copy link
Member Author

bdraco commented Jun 20, 2023

Thanks for the review

@jbouwh
Copy link
Contributor

jbouwh commented Jun 20, 2023

Thanks for the review

The type hint was added so that the ignore could be removed.

@bdraco
Copy link
Member Author

bdraco commented Jun 20, 2023

Thanks for the review

The type hint was added so that the ignore could be removed.

Unfortunately it trades one ignore for another so I took it back out

Error: homeassistant/components/websocket_api/connection.py:162: error: Incompatible types in assignment (expression has type "Union[Dict[str, JsonValueType], List[JsonValueType], str, int, float, None]", variable has type "int")  [assignment]
Error: Process completed with exit code 1.

@bdraco
Copy link
Member Author

bdraco commented Jun 20, 2023

Messed around with this for a bit and since it's only going to get to that path on garbage input, the ignore makes sense here

@bdraco bdraco merged commit 3f18f51 into dev Jun 20, 2023
54 checks passed
@bdraco bdraco deleted the ws_api_cover branch June 20, 2023 14:21
@backcountrymountains
Copy link

Not to go off topic, but is there a way for an average HAOS user to take advantage of these memory leak fixes in the frontend without setting up a dev environment? The memory leaks have made my system unstable.
Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants