Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Meteo France blocked config entry when weather alert API fails #94911

Merged
merged 2 commits into from Jun 22, 2023

Conversation

Quentame
Copy link
Member

@Quentame Quentame commented Jun 20, 2023

Proposed change

Fixes #94839: allow Météo-France config entry to continue even if the alert API fails.
2 reasons to investigate:

  • API server error: which is temporary
  • API changes: which needs an integration rework

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @hacf-fr, @oncleben31, mind taking a look at this pull request as it has been labeled with an integration (meteo_france) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of meteo_france can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign meteo_france Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@gjohansson-ST
Copy link
Member

This doesn't necessarily seem like the right thing to do?
If the api call fails we just disregard from this alert coordinator and continue?

@Quentame
Copy link
Member Author

This doesn't necessarily seem like the right thing to do?

If the api call fails we just disregard from this alert coordinator and continue?

That's exactly what I'm doing here 🤔

See #94839 (comment) : Now none of the sensor or weather platforms are working, with this fix: the alert sensor is bypassed if the API call fails, but the integration is working globally.

I'll investigate more on this, as described in the description: if this is a temporary error (occasional server issue) or a definitive one (API changes and need to rewrite all the alert part of the integration).

But I need more time, and users, myself included, needs this integration to work.

Copy link
Contributor

@vingerha vingerha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed wrt to fixing the root cause. Tested on own instance

@MartinHjelmare MartinHjelmare changed the title Fix: do not block config entry when weather alert API fails Fix Meteo France blocked config entry when weather alert API fails Jun 21, 2023
@Quentame Quentame enabled auto-merge (squash) June 21, 2023 05:57
@home-assistant home-assistant bot marked this pull request as draft June 21, 2023 09:50
auto-merge was automatically disabled June 21, 2023 09:50

Pull request was converted to draft

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Quentame Quentame marked this pull request as ready for review June 22, 2023 13:45
@home-assistant home-assistant bot requested a review from frenck June 22, 2023 13:45
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Quentame 👍

../Frenck

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 22, 2023
@Quentame Quentame merged commit ede84d7 into home-assistant:dev Jun 22, 2023
23 checks passed
@Quentame Quentame deleted the meteo_france/fix_alert_catch branch June 22, 2023 13:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cherry-picked cla-signed integration: meteo_france Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Météo France integration fails
4 participants