New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Meteo France blocked config entry when weather alert API fails #94911
Fix Meteo France blocked config entry when weather alert API fails #94911
Conversation
Hey there @hacf-fr, @oncleben31, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This doesn't necessarily seem like the right thing to do? |
That's exactly what I'm doing here 🤔 See #94839 (comment) : Now none of the sensor or weather platforms are working, with this fix: the alert sensor is bypassed if the API call fails, but the integration is working globally. I'll investigate more on this, as described in the description: if this is a temporary error (occasional server issue) or a definitive one (API changes and need to rewrite all the alert part of the integration). But I need more time, and users, myself included, needs this integration to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed wrt to fixing the root cause. Tested on own instance
Pull request was converted to draft
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Quentame 👍
../Frenck
Proposed change
Fixes #94839: allow Météo-France config entry to continue even if the alert API fails.
2 reasons to investigate:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: