Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async_scanner_devices_by_address unexpectedly combining Bluetooth scanners #94990

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Fix async_scanner_devices_by_address unexpectedly combining Bluetooth scanners #94990

merged 3 commits into from
Jun 22, 2023
+32 −39

Commits on Jun 21, 2023

  1. Fix async_scanner_devices_by_address unexpectedly combining scanners 

    Since _get_scanners_by_type returned the scanners without making a copy,
async_scanner_devices_by_address would extend the list of scanners and
unexpectedly add the non-connectable ones to the connectable list.

Refactor to remove the _get_X_by_type functions to avoid this
pattern
    @bdraco
    bdraco committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    3ad4ad6 View commit details
    Browse the repository at this point in the history

  2. Update homeassistant/components/bluetooth/manager.py

    @bdraco
    bdraco committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    930e5c0 View commit details
    Browse the repository at this point in the history

  3. use chain instead

    @bdraco
    bdraco committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    8a4a936 View commit details
    Browse the repository at this point in the history