EnergyID integration #95006
EnergyID integration #95006
Conversation
home-assistant
bot
added
cla-error
has-tests
new-integration
integration: energyid
labels
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
1 similar comment
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
| { | ||
| "domain": "energyid", | ||
| "name": "EnergyID", | ||
| "integrations": ["energyid"] | ||
| } |
There was a problem hiding this comment.
A brand is only created if there are more integrations under 1 company brand. For example Google has everything from Google Agenda to YouTube and Philips has Philips hue and Philips TV. So this integration is not a brand.
There was a problem hiding this comment.
I understand. So this json file can simply be removed?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
| @@ -342,6 +342,7 @@ build.json @home-assistant/supervisor | |||
| /tests/components/emulated_kasa/ @kbickar | |||
| /homeassistant/components/energy/ @home-assistant/core | |||
| /tests/components/energy/ @home-assistant/core | |||
| /homeassistant/components/energyid/ @JrtPec | |||
There was a problem hiding this comment.
Hmm, the tests should also be added to your name. I think hassfest might be having a bad day with it (I also saw another case of this recently, so maybe its something we have to fix in hassfest)
| @@ -342,6 +342,7 @@ build.json @home-assistant/supervisor | |||
| /tests/components/emulated_kasa/ @kbickar | |||
| /homeassistant/components/energy/ @home-assistant/core | |||
| /tests/components/energy/ @home-assistant/core | |||
| /homeassistant/components/energyid/ @JrtPec | |||
There was a problem hiding this comment.
| /homeassistant/components/energyid/ @JrtPec | |
| /homeassistant/components/energyid/ @JrtPec | |
| /tests/components/energyid/ @JrtPec |
| await dispatcher.client.get_policy() | ||
| except aiohttp.ClientResponseError as error: | ||
| _LOGGER.error("Could not validate webhook client") | ||
| raise ConfigEntryAuthFailed from error |
There was a problem hiding this comment.
ConfigEntryAuthFailed should only be raised when the integration has a reauth flow and you dont have one yet. So please raise ConfigEntryError instead
|
|
||
| async def async_handle_state_change(self, event: Event) -> bool: | ||
| """Handle a state change.""" | ||
| await self._upload_lock.acquire() |
There was a problem hiding this comment.
Would it maybe work if you did:
async with self._upload_lock:This way you don't have to manually acquire and release locks. (and if you dislike the extra indent, you could move this function to _async_handle_state_change and call it like
async def async_handle_state_change() -> bool:
async with self._upload_lock:
await self._async_handle_state_change()
|
Oh and sorry for the wait |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Introducing the EnergyID integration! EnergyID is an online energy monitoring platform. This integration allows you send sensors from within Home Assistant (eg. energy meters, solar panels, batteries, ...) to your EnergyID-record, using their webhooks.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: