Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new properties to the weather entity in Accuweather integration #95110

Merged
merged 4 commits into from Jun 24, 2023
Merged

Add new properties to the weather entity in Accuweather integration #95110

merged 4 commits into from Jun 24, 2023

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Jun 23, 2023

Breaking change

Proposed change

Adds new properties apparent_temperature, cloud_cover, dev_point and wind_gust_speed to the weather entity.

Waiting for #95108

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bieniu bieniu marked this pull request as ready for review June 23, 2023 13:03
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Just to check but no humidity in forecast?

@bieniu
Copy link
Member Author

bieniu commented Jun 24, 2023

@gjohansson-ST Unfortunately there is no humidity and dew point in the forecast data for Accuwather.

@gjohansson-ST gjohansson-ST merged commit fe9366e into home-assistant:dev Jun 24, 2023
23 checks passed
@bieniu bieniu deleted the accuweather-new-properties branch June 24, 2023 10:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed has-tests integration: accuweather new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: platinum
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants