-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action
attribute to Humidifier entity
#95131
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
9ef7e5e
to
2c8a7c1
Compare
9b1fe9d
to
501e9d1
Compare
501e9d1
to
335890f
Compare
@Shulyaka Is there is frontend PR depending on this one? |
I'd put it this way: once this feature is implemented, that frontend PR will make use of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Shulyaka 👍
Proposed change
Add
action
attribute to Humidifier entity.Implements home-assistant/architecture#731
Type of change
Additional information
action
attribute to Humidifier developers.home-assistant#1817Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: